Hi Patrick,

On 04/11/2016 11:57, [email protected] wrote:
> From: Patrick Bruenn <[email protected]>
> 
> Add CX9020 board based on mx53loco.
> Add simplified imx53 base device tree from kernel v4.8-rc8, to reuse
> serial_mxc with DTE and prepare for device tree migration of other
> functions and imx53 devices.
> 
> The CX9020 differs from i.MX53 Quick Start Board by:
> - use uart2 instead of uart1
> - DVI-D connector instead of VGA
> - no audio
> - CCAT FPGA connected to emi
> - enable rtc
> 
> Signed-off-by: Patrick Bruenn <[email protected]>
> 
> ---
> Version 4 should address most of the issues Stefan, Jagan and Simon pointed 
> out.

There is still some small issues that avoid the patches to be merged.
Board cannot be built due to missing CONFIG_:

       arm:  +   mx53cx9020
+drivers/video/cfb_console.c: In function 'cfg_video_init':
+drivers/video/cfb_console.c:2022:23: error: 'CONFIG_SYS_CONSOLE_FG_COL'
undeclared (first use in this function)
+drivers/video/cfb_console.c:2022:23: note: each undeclared identifier
is reported only once for each function it appears in
+drivers/video/cfb_console.c:2025:23: error: 'CONFIG_SYS_CONSOLE_BG_COL'
undeclared (first use in this function)
+make[3]: *** [drivers/video/cfb_console.o] Error 1
+make[2]: *** [drivers/video] Error 2
+make[1]: *** [drivers] Error 2


I have checked why and I could fix with the following patch:


---
 configs/mx53cx9020_defconfig | 6 ++++++
 include/configs/mx53cx9020.h | 4 ----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/configs/mx53cx9020_defconfig b/configs/mx53cx9020_defconfig
index 3603907..6954cf5 100644
--- a/configs/mx53cx9020_defconfig
+++ b/configs/mx53cx9020_defconfig
@@ -11,6 +11,7 @@ CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_MMC=y
 #CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_VIDEO=y
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
@@ -27,3 +28,8 @@ CONFIG_FPGA_CYCLON2=y
 CONFIG_CMD_FPGA=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX5=y
+# CONFIG_VIDEO_SW_CURSOR is not set
+CONFIG_CFB_CONSOLE=y
+CONFIG_VGA_AS_SINGLE_DEVICE=y
+CONFIG_SYS_CONSOLE_BG_COL=0x00
+CONFIG_SYS_CONSOLE_FG_COL=0xa0
diff --git a/include/configs/mx53cx9020.h b/include/configs/mx53cx9020.h
index ac8b2a2..87c75d4 100644
--- a/include/configs/mx53cx9020.h
+++ b/include/configs/mx53cx9020.h
@@ -187,11 +187,7 @@

 /* Framebuffer and LCD */
 #define CONFIG_PREBOOT
-#define CONFIG_VIDEO
 #define CONFIG_VIDEO_IPUV3
-#define CONFIG_CFB_CONSOLE
-#define CONFIG_VGA_AS_SINGLE_DEVICE
-#define CONFIG_SYS_CONSOLE_IS_IN_ENV
 #define CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE
 #define CONFIG_VIDEO_BMP_RLE8
 #define CONFIG_SPLASH_SCREEN
-- 
2.7.4

Now on you: if you agree, I can integrate this fix into your patch and
merge it into the u-boot-imx tree. If you disagree, please check it and
send an update version, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to