On 12 January 2017 at 10:47, Moritz Fischer <[email protected]> wrote: > > Replace dm_i2c_write() / dm_i2c_read() with transaction using > struct i2c_msg[2] in order to allow for i2c controller to detect > write/read cycle to emit a repeated start condition. > > Signed-off-by: Moritz Fischer <[email protected]> > Cc: Simon Glass <[email protected]> > Cc: [email protected] > --- > Hi Simon, > > since I don't have a v2 protocol EC I couldn't test this, > but I noticed when playing around with a v3 one, that it would simply ignore > the packets if they don't have a repeated start condition (which from my > understanding) > you can *only* get if you use struct i2c_msg, since otherwise the driver has > no way of > knowing your intention. > > Do you have a v2 board around to test this? > > Cheers, > > Moritz > --- > drivers/misc/cros_ec_i2c.c | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-)
Acked-by: Simon Glass <[email protected]> Tested on snow: Tested-by: Simon Glass <[email protected]> _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
