On 14/02/17 22:12, Tom Rini wrote: > On Tue, Feb 14, 2017 at 01:26:24PM -0600, Nishanth Menon wrote: >> On 02/14/2017 01:20 PM, Tom Rini wrote: >>> On Tue, Feb 14, 2017 at 01:18:20PM -0600, menon.nisha...@gmail.com wrote: >>>> On Mon, Feb 13, 2017 at 7:27 AM, Tom Rini <tr...@konsulko.com> wrote: >>>>> On Mon, Feb 13, 2017 at 01:34:52PM +0200, Uri Mashiach wrote: >>>>> >>>>>> The SOC family symbol CONFIG_AM57XX was removed by the commit >>>>>> 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX". >>>>>> >>>>>> The symbol is needed by the XHCI OMAP USB driver. >>>>>> Without the symbol all the AM57x targets symbols should be ored in the >>>>>> ifdef'ery. >>>>>> >>>>>> Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il> >>>>> >>>>> We need to introduce it into Kconfig files now, thanks! >>>> >>>> DRA7 and AM57xx are literally the same. the #ifdeffery in USB is more >>>> to do which port to use rather than having anything to do with DRA7 Vs >>>> AM57xx. >>> >>> Yes, agreed. And we need to solve this, and introduce some Kconfig >>> CONFIG symbol to deal with it. Maybe the better way to look at this is, >>> can we have DRA7xx boards configured in the way Uri wants to be able to >>> configure the AM57xx board he's working with? And vice versa? The >>> answer to that will help drive what the right CONFIG_xxx name is. >> >> Should'nt be ideally done via DM model instead? I have no >> understanding of USB integration done in u-boot to comment better. > > That's also something that could be explored. >
Yes, ideally this should be taken care of by DM. Till that migration is complete I'm fine with fixing this temporarily. OMAP5, DRA7, AM57 and AM43 use different XHCI_BASE address. -- cheers, -roger _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
