On Isn, 2017-02-27 at 11:00 +0100, Marek Vasut wrote: > On 02/27/2017 10:45 AM, Ley Foon Tan wrote: > > > > On Sab, 2017-02-25 at 22:20 +0100, Marek Vasut wrote: > > > > > > On 02/22/2017 10:47 AM, Ley Foon Tan wrote: > > > > > > > > > > > > add i2c, timer and other A10 defines. > > > Start with capital letter please. > > > > > > > > > > > > > > > Signed-off-by: Dinh Nguyen <dingu...@opensource.altera.com> > > > > Signed-off-by: Ley Foon Tan <ley.foon....@intel.com> > > > > --- > > > > arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 8 > > > > +++++++- > > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h > > > > b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h > > > > index a7056d4..d3dea0b 100644 > > > > --- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h > > > > +++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h > > > > @@ -1,5 +1,5 @@ > > > > /* > > > > - * Copyright (C) 2014 Altera Corporation <www.altera.com> > > > > + * Copyright (C) 2014-2017 Altera Corporation <www.altera.com> > > > > * > > > > * SPDX-License-Identifier: GPL-2.0+ > > > > */ > > > > @@ -29,14 +29,20 @@ > > > > #define SOCFPGA_MPUL2_ADDRESS 0xfffff00 > > > > 0 > > > > #define SOCFPGA_I2C0_ADDRESS 0xffc02200 > > > > #define SOCFPGA_I2C1_ADDRESS 0xffc02300 > > > > +#define SOCFPGA_I2C2_ADDRESS 0xffc02400 > > > > +#define SOCFPGA_I2C3_ADDRESS 0xffc02500 > > > > +#define SOCFPGA_I2C4_ADDRESS 0xffc02600 > > > Shouldn't all this come from DT already ? What's the point of > > > having > > > those macros at all ? > > They are used for CONFIG_SYS_I2C_BASE in socfpag_common.h now. I > > will > > add #ifndef CONFIG_DM_I2C switch in socfpga_common.h and remove > > these > > defines from this file. > Ah hmmmmm, ok, then keep them. Unless you want to convert the i2c > driver > to DM of course, which would be more then welcome. Then I will keep them for now. Yes, converting to DM is better, we will try to that when enabling i2c. > > > > > > > > > > > > > > > > > > > > > #define SOCFPGA_ECC_OCRAM_ADDRESS 0xff8c3000 > > > > #define SOCFPGA_UART0_ADDRESS 0xffc0200 > > > > 0 > > > > #define SOCFPGA_OSC1TIMER0_ADDRESS 0xffd00000 > > > > +#define SOCFPGA_OSC1TIMER1_ADDRESS 0xffd00100 > > > > #define SOCFPGA_CLKMGR_ADDRESS 0xffd040 > > > > 00 > > > > #define SOCFPGA_RSTMGR_ADDRESS 0xffd050 > > > > 00 > > > > > > > > #define SOCFPGA_SDR_ADDRESS 0xffcfb000 > > > > +#define SOCFPGA_NOC_L4_PRIV_FLT_OFST 0xffd11000 > > > > +#define SOCFPGA_NOC_FW_H2F_SCR_OFST 0xffd13500 > > > > #define SOCFPGA_SDR_SCHEDULER_ADDRESS 0xffd1240 > > > > 0 > > > > #define SOCFPGA_SDR_FIREWALL_OCRAM_ADDRESS 0xffd13200 > > > > #define SOCFPGA_SDR_FIREWALL_MPU_FPGA_ADDRESS 0xffd1330 > > > > 0 > > > > > Thanks
Regards Ley Foon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
