On Wed, Mar 15, 2017 at 8:01 PM, Andy Shevchenko <[email protected]> wrote: > On Sun, Mar 12, 2017 at 10:21 PM, Simon Glass <[email protected]> wrote: >> Hi Andy, >> >> On 5 March 2017 at 12:17, Andy Shevchenko >> <[email protected]> wrote: >>> This simple PMU driver enables access to MMC controllers during probe >>> so tangier_sdhci can probe and be useful. >>> >>> In the future it might be expanded to cover other Intel MID platforms, >>> that's why it's called intel_mid_pmu.c. >>> >>> Signed-off-by: Felipe Balbi <[email protected]> >>> Signed-off-by: Andy Shevchenko <[email protected]> >> >> Please consider my comments on the previous driver to apply to this one also. >> >> One more thing - you cannot call device_probe() from the bind >> function. That is breaking the rules. >> >> Instead, it should be found by the first user, perhaps using syscon or >> perhaps with a device_get_...() function, and that will automatically >> probe it. > > While SCU works fine with this model, PMU doesn't. > MMC (sdhci) requires to power on controllers, it looks like device > can't be probed at that time (too early). What do you suggest to do?
Whoof, found three mistakes - two typos in my code and an issue in sdhci generic driver. Works now. -- With Best Regards, Andy Shevchenko _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
