Dear Ben Warren, In message <[email protected]> you wrote: > > > IMHO we should aim to make this driver less complicated, not more. Do we > really need to malloc and free each time this interface is turned on or off? > Why not just initialize the pointers to NULL, and malloc() only the first > time the init() function is called? You could then get rid of the free() > calls in the halt function. > > U-boot is very transient in nature. Once we launch a kernel all the memory > essentially gets freed anyway.
Full ACK from me. And we don't use that many different Ethernet drivers in parallel either that the RAM footprint would hurt. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] Genitiv ins Wasser, weil's Dativ ist! _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
