On Wed, May 03, 2017 at 11:44:11PM +0200, [email protected] wrote: > The logical expression to check the dtb is incorrect in > load_devicetree. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt <[email protected]> > Reviewed-by: Hannes Schmelzer <[email protected]> > Acked-by: Hannes Schmelzer <[email protected]> > --- > I do not have a board for testing. > Please, review carefully. > --- > board/BuR/common/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/BuR/common/common.c b/board/BuR/common/common.c > index 876150402c..c0316b9ebd 100644 > --- a/board/BuR/common/common.c > +++ b/board/BuR/common/common.c > @@ -265,7 +265,7 @@ static int load_devicetree(void) > char *dtbname = getenv("dtb"); > char *dtbdev = getenv("dtbdev"); > char *dtppart = getenv("dtbpart"); > - if (!dtbdev || !dtbdev || !dtbname) { > + if (!dtbdev || !dtbpart || !dtbname) { > printf("%s: <dtbdev>/<dtbpart>/<dtb> missing.\n", __func__); > return -1; > }
This breaks some boards such as brppt1_mmc, which I agree doesn't make a lot of sense with just the above context, can you please test building 'BuR' via buildman? Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
