Hi Patrick, On 11 May 2017 at 01:51, Patrick Delaunay <[email protected]> wrote: > Signed-off-by: Patrick Delaunay <[email protected]> > Reviewed-by: Christophe KERELLO <[email protected]> > --- > > Changes in v6: > - invalid offset my_lba in is_secondary_gpt_valid_mtd() > the secondary GPT header wasn't detected > - add comment for functions > > Changes in v5: > - solve warning and error > (dont' include linux/mtd/mtd.h in part.h) > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > disk/Kconfig | 17 ++ > disk/Makefile | 1 + > disk/part_efi_mtd.c | 456 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > doc/README.gpt.mtd | 187 +++++++++++++++++++++ > include/part.h | 42 ++++- > 5 files changed, 701 insertions(+), 2 deletions(-) > create mode 100644 disk/part_efi_mtd.c > create mode 100644 doc/README.gpt.mtd
Reviewed-by: Simon Glass <[email protected]> Can you please look at a few nits if you send a new version, or perhaps as a follow-up patch. is_gpt_valid_mtd() could use a full function comment , including what the caller should do with the buffer. common.h should go first in the #include sequence Also, how can we add a sandbox test for this? Regards, Simon _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
