On 22/05/17 20:40, Tom Rini wrote: > In situations like an autobuilder we are likely to not have bl31.bin > present and thus would fail to build and propagate the error upwards. > Instead, print a big warning to stderr so that human will see that > something is wrong but complete the build.
Yeah, that sounds like a good idea. Thanks! To make this even more useful, we should both mention either ATF or "ARM Trusted firmware" and board/sunxi/README.sunxi64, so that the users have a clue how to fix it. > Cc: Andre Przywara <andre.przyw...@arm.com> > Cc: Simon Glass <s...@chromium.org> > Cc: Maxime Ripard <maxime.rip...@free-electrons.com> > Signed-off-by: Tom Rini <tr...@konsulko.com> With those hints above added: Reviewed-by: Andre Przywara <andre.przyw...@arm.com> Cheers, Andre. > --- > board/sunxi/mksunxi_fit_atf.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/board/sunxi/mksunxi_fit_atf.sh b/board/sunxi/mksunxi_fit_atf.sh > index ecea1b839bdf..0deed6eeb14d 100755 > --- a/board/sunxi/mksunxi_fit_atf.sh > +++ b/board/sunxi/mksunxi_fit_atf.sh > @@ -7,6 +7,11 @@ > > [ -z "$BL31" ] && BL31="bl31.bin" > > +if [ ! -f $BL31 ]; then > + echo "WARNING: BL31 file $BL31 NOT found, resulting binary is > non-functional" >&2 > + BL31=/dev/null > +fi > + > cat << __HEADER_EOF > /dts-v1/; > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
