Hi Stephen, On 9 June 2017 at 16:57, Stephen Warren <[email protected]> wrote: > On 06/09/2017 04:37 PM, Simon Glass wrote: >> >> Hi Tom, >> >> This is without the two offending patches that broke BUILD_TAG. I'll >> figure >> out a sandbox test for this and resubmit those patches later. >> >> >> The following changes since commit >> 156d64fa55e9914b144c5e83f2a9e13d1223a4d3: >> >> Merge git://git.denx.de/u-boot-rockchip (2017-06-08 12:14:11 -0400) >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-dm.git >> >> for you to fetch changes up to 9620d87259572ef21f0df60988d9a932ca673779: >> >> cmd/fdt: support single value replacement within an array (2017-06-09 >> 13:45:34 -0600) > > > This version passes my Jenkins tests OK. > > I did try to reproduce the issue in the original pull request, but wasn't > able to immediately. It didn't seem to be solely/simply related to > BUILD_TAG. Unfortunately, I have a few fire-fights going on so can't spend > any more time on this today; perhaps next week.
Habeus corpus. I can repeat the problem on beaver - I don't get a crash but I clearly see a stack overflow which I'm sure could cause a crash. The problem is that snprintf() returns the required buffer size rather than the numberof bytes written to the buffer. I forgot about that. I'll send an updated patch. Of course the bigger problem is that my size is not large enough so I will have to increase it (and thus hide the fault). Regards, Simon _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
