> -----Original Message----- > From: Marek Vasut [mailto:[email protected]] > Sent: vendredi 21 juillet 2017 14:54 > To: Patrick DELAUNAY <[email protected]>; [email protected] > Cc: Patrice CHOTARD <[email protected]>; [email protected]; > Jean-Jacques Hiblot <[email protected]>; Christophe KERELLO > <[email protected]>; Simon Glass <[email protected]>; Masahiro > Yamada <[email protected]>; Konstantin Porotchkin > <[email protected]>; Bin Meng <[email protected]>; Philipp Tomsich > <[email protected]>; Uri Mashiach > <[email protected]>; Stefan Roese <[email protected]> > Subject: Re: [PATCH] usb: add dependency with generic PHY support > Importance: High > > On 07/21/2017 02:50 PM, Patrick Delaunay wrote: > > select CONFIG_PHY when phy is used in driver > > - USB_EHCI_GENERIC > > - USB_OHCI_GENERIC > > - USB_XHCI_DWC3 > > Why would I want PHY enabled on boards which do not use PHY framework > at all ? I have boards with EHCI, which do not use PHY framework, so this just > adds bloat IMO.
Just to avoid compilation issue if you don't have compilation flag in driver or in PHY header (replace by no-obs phy) But perhaps I misunderstanding the conclusion for [PATCH 1/1] dm: phy: add missing #ifdef CONFIG_PHY => NOOPS phy is added => And the Patrice patch is dropped !? But in fact if the last Patrice patch is accepted, the stub for phy is added directly in .h file and compilation issues are solved. So you can forget my patch and sorry for disturbance. Regards Patrick > > Signed-off-by: Patrick Delaunay <[email protected]> > > --- > > > > drivers/usb/host/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index > > 67ad72b..553f74b 100644 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -17,6 +17,7 @@ if USB_XHCI_HCD > > > > config USB_XHCI_DWC3 > > bool "DesignWare USB3 DRD Core Support" > > + select PHY > > help > > Say Y or if your system has a Dual Role SuperSpeed > > USB controller based on the DesignWare USB3 IP Core. > > @@ -161,6 +162,7 @@ config USB_EHCI_GENERIC > > bool "Support for generic EHCI USB controller" > > depends on OF_CONTROL > > depends on DM_USB > > + select PHY > > default n > > ---help--- > > Enables support for generic EHCI controller. > > @@ -186,6 +188,7 @@ config USB_OHCI_GENERIC > > depends on OF_CONTROL > > depends on DM_USB > > select USB_HOST > > + select PHY > > ---help--- > > Enables support for generic OHCI controller. > > > > > > > -- > Best regards, > Marek Vasut _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
