Hi Stefano,

On Mon, Jul 24, 2017 at 7:13 AM, Stefano Babic <[email protected]> wrote:

> +int board_mmc_getcd(struct mmc *mmc)
> +{
> +       struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
> +       int ret = 0;
> +
> +       switch (cfg->esdhc_base) {
> +       case USDHC2_BASE_ADDR:
> +               ret = !gpio_get_value(USDHC2_CD_GPIO);

Is this GPIO read really needed?

> +               ret = 1;

as it is overwritten here.

> +#define PHYS_SDRAM_SIZE                (1u * 1024 * 1024 * 1024)

This definition seems to be unused.
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to