On Tue, Aug 08, 2017 at 03:37:03PM +0200, Philipp Tomsich wrote:

> Moving SPL_LDSCRIPT to Kconfig triggered an unfortunate attempt of
> command substitution, as the sourced auto.conf may include $(ARCH)
> which tries to execute a command 'ARCH'.
> This showed up as a warning similar to the following:
>   include/config/auto.conf: line 209: ARCH: command not found
> This change does no longer attempt to source auto.conf, but rather
> passes it through awk to retrieve the values for CONFIG_LOCALVERSION
> and CONFIG_LOCALVERSION_AUTO.  This will also mitigate the risk of
> unintended command substitution.
> Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com>
> Reported-by: Andy Yan <andy....@rock-chips.com>

Reviewed-by: Tom Rini <tr...@konsulko.com>

I do wonder if we can get this into the kernel as well.


Attachment: signature.asc
Description: Digital signature

U-Boot mailing list

Reply via email to