Dear Daniel Hobi, In message <[email protected]> you wrote: > Depending on offset, flash size and the number of bad blocks, > get_len_incl_bad may return a too small value which may lead to: > > 1) If there are no bad blocks, nand_{read,write}_skip_bad chooses the > bad block aware read/write code. This may hurt performance, but does > not have any adverse effects. > > 2) If there are bad blocks, the nand_{read,write}_skip_bad may choose > the bad block unaware read/write code (if len_incl_bad == *length) > which leads to corrupted data. > > Signed-off-by: Daniel Hobi <[email protected]> > --- > @Scott: please review > @Wolfgang: please consider for 2009.11 > > diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c
Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] "Intelligence without character is a dangerous thing." - G. Steinem _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
