Jagan,

please revise — after applying this patch, the build fails with:

>        arm:  +   vyasa-rk3288                        
> +cmd/built-in.o: In function `do_usb_mass_storage':
> +cmd/usb_mass_storage.c:164: undefined reference to `board_usb_init'
> +cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
> +cmd/usb_mass_storage.c:177: undefined reference to `g_dnl_register'
> +cmd/usb_mass_storage.c:187: undefined reference to 
> `g_dnl_board_usb_cable_connected'
> +cmd/usb_mass_storage.c:194: undefined reference to 
> `g_dnl_board_usb_cable_connected'
> +cmd/usb_mass_storage.c:215: undefined reference to 
> `usb_gadget_handle_interrupts'
> +cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
> +cmd/usb_mass_storage.c:233: undefined reference to `g_dnl_unregister'
> +cmd/usb_mass_storage.c:235: undefined reference to `board_usb_cleanup'
> +arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion fail 
> /home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696
> +arm-unknown-linux-gnueabi-ld.bfd: error: required section '.rel.plt' not 
> found in the linker script
> +arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation
> +make[1]: *** [u-boot] Error 1
> +make: *** [sub-make] Error 2


Thanks,
Philipp.

> On 12 Sep 2017, at 10:37, Philipp Tomsich 
> <philipp.toms...@theobroma-systems.com> wrote:
> 
>> From: Jagan Teki <ja...@amarulasolutions.com>
>> 
>> This patch adds support for Vyasa RK3288 initial board
>> from Amarula Solutions.
>> 
>> Boot from SDMMC:
>> ---------------
>> U-Boot SPL 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45)
>> Trying to boot from MMC1
>> 
>> U-Boot 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45 +0530)
>> 
>> Model: Amarula Vyasa-RK3288
>> DRAM:  2 GiB
>> MMC:   dwmmc@ff0c0000: 1
>> *** Warning - bad CRC, using default environment
>> 
>> In:    serial@ff690000
>> Out:   serial@ff690000
>> Err:   serial@ff690000
>> Model: Amarula Vyasa-RK3288
>> Net:   Net Initialization Skipped
>> No ethernet found.
>> Hit any key to stop autoboot:  0
>> =>
>> 
>> Reviewed-by: Simon Glass <s...@chromium.org>
>> Signed-off-by: Jagan Teki <ja...@amarulasolutions.com>
>> Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com 
>> <mailto:philipp.toms...@theobroma-systems.com>>
>> ---
>> Changes for v3:
>> - Remove CONFIG_ENV_IS_IN_MMC from include file
>> - Update commit message with company name
>> - Fix proper board name on MAINTAINERS file
>> Changes for v2:
>> - Fix commit message
>> - Move CONFIG_ENV_IS_IN_MMC to configs
>> 
>> arch/arm/dts/Makefile                     |   1 +
>> arch/arm/dts/rk3288-vyasa.dts             | 327 
>> ++++++++++++++++++++++++++++++
>> arch/arm/mach-rockchip/rk3288/Kconfig     |  11 +
>> board/amarula/vyasa-rk3288/Kconfig        |  12 ++
>> board/amarula/vyasa-rk3288/MAINTAINERS    |   6 +
>> board/amarula/vyasa-rk3288/Makefile       |   7 +
>> board/amarula/vyasa-rk3288/vyasa-rk3288.c |   7 +
>> configs/vyasa-rk3288_defconfig            |  63 ++++++
>> include/configs/vyasa-rk3288.h            |  22 ++
>> 9 files changed, 456 insertions(+)
>> create mode 100644 arch/arm/dts/rk3288-vyasa.dts
>> create mode 100644 board/amarula/vyasa-rk3288/Kconfig
>> create mode 100644 board/amarula/vyasa-rk3288/MAINTAINERS
>> create mode 100644 board/amarula/vyasa-rk3288/Makefile
>> create mode 100644 board/amarula/vyasa-rk3288/vyasa-rk3288.c
>> create mode 100644 configs/vyasa-rk3288_defconfig
>> create mode 100644 include/configs/vyasa-rk3288.h
>> 
> 
> Acked-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com 
> <mailto:philipp.toms...@theobroma-systems.com>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de <mailto:U-Boot@lists.denx.de>
> https://lists.denx.de/listinfo/u-boot <https://lists.denx.de/listinfo/u-boot>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to