On 13 September 2017 at 02:20, Dr. Philipp Tomsich <philipp.toms...@theobroma-systems.com> wrote: > >> On 13 Sep 2017, at 06:26, Simon Glass <s...@chromium.org> wrote: >> >> On 11 September 2017 at 05:59, Philipp Tomsich >> <philipp.toms...@theobroma-systems.com> wrote: >>> The Makefile already tests for SPL_DM_REGULATOR_FIXED, but Kconfig >>> does not provide it. This adds SPL_DM_REGULATOR_FIXED to Kconfig. >>> >>> Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >>> --- >>> >>> drivers/power/regulator/Kconfig | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> >> Should that default to y? > > I am undecided, as pretty much any default will be wrong for most people. > Fortunately it can be easily changed via defconfig or from implying it from > one of the other Kconfig sections. > > My reasoning behind not making it the default was that a large number of > boards will have DM_REGULATOR_FIXED enabled (e.g. for enabling some > of the USB path), but many of the boards will not need it at the SPL stage. > If we’d make this the default, we might see increases in size (and some SPL > stages exceeding their size limit) from this change. > > I’d more more than happy to make it the default, though.
Seems fine, I understand. - Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot