On Monday 14 December 2009 01:39:20 Peter Tyser wrote: > > > Before I respin, do you have any issue with the fact that the > > > CFLAGS_lib will apply to both /lib and /arch/blackfin/lib? > > > > sorry, i dont understand what you mean. i must have missed the patch > > you're implicitly referring to ? > > I mentioned the issue briefly in the cover letter, but patch 2 is the > specific patch I'm referring to. Moving lib_generic/ to lib/ causes > changes like: > > diff --git a/board/bf518f-ezbrd/config.mk b/board/bf518f-ezbrd/config.mk > index f85bef5..e0c459e 100644 > --- a/board/bf518f-ezbrd/config.mk > +++ b/board/bf518f-ezbrd/config.mk > @@ -26,7 +26,7 @@ > # This is not actually used for Blackfin boards so do not change it > #TEXT_BASE = do-not-use-me > > -CFLAGS_lib_generic += -O2 > +CFLAGS_lib += -O2 > CFLAGS_lzma += -O2 > > So after my series, both lib/ and arch/blackfin/lib will be compiled > with the -O2 flag if I'm understanding the CLFAGS_xyz concept. > Previously, only lib_generic/ was compiled with -O2. Blackfin boards > are the only current users of the CFLAGS_<dir> feature, so I thought you > might have some issues with the change:)
yes, that is how the CFLAGS thing currently works. previously this was OK because there werent any like-named dirs in the tree so there wasnt any collision. i guess we can change the syntax so you have to give it the full- intree path ... shouldnt be a big deal. this one line change in config.mk: BCURDIR = $(CURDIR:$(obj)%=%) then you'd have to do CFLAGS_arch/blackfin/lib = -O2 -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
