On 21 September 2017 at 10:30, Heinrich Schuchardt <[email protected]> wrote:
> Provide comments describing the boot service functions.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
>  lib/efi_loader/efi_boottime.c | 640 
> +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 638 insertions(+), 2 deletions(-)

Great to see this - but please can you put these comments in the
header file? That's the file that people read to see the API.

nit: efi_locate_protocol() needs a @return
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to