> On 30 Sep 2017, at 22:32, Tom Rini <tr...@konsulko.com> wrote: > > On Sat, Sep 30, 2017 at 06:08:02PM +0200, Dr. Philipp Tomsich wrote: >> Simon, >> >>> On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich >>> <philipp.toms...@theobroma-systems.com> wrote: >>> >>> >>>> On 28 Sep 2017, at 14:35, Simon Glass <s...@chromium.org> wrote: >>>> >>>> This currently causes a warning in sandbox and will not do the right >>>> thing: >>>> >>>> drivers/core/read.c: In function ‘dev_read_addr_ptr’: >>>> drivers/core/read.c:64:44: warning: cast to pointer from integer of >>>> different size [-Wint-to-pointer-cast] >>>> return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr; >>>> >>>> Use map_sysmem() which is the correct way to convert an address to a >>>> pointer. >>>> >>>> Fixes: c131c8bca8 (dm: core: add dev_read_addr_ptr()) >>>> Signed-off-by: Simon Glass <s...@chromium.org> >>> >>> Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >> >> >> Acked-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >> >> I’ll pull this one in through u-boot-rockchip now, as Tom raised it as a >> build >> issue against my last pull-request. > > Well, that's for the minor existing warning. The big problem is the > build failures :)
I already backed Jagan’s change to mach-tegra/cache.c out (missed that during my review and testing) and this is already running on Travis. I understood you that I should also address those warnings related to the Rockchip code? If not, I’d rather have this one go through the -dm tree… _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
