On Thu, Oct 5, 2017 at 8:07 AM, <chin.liang....@intel.com> wrote: > From: Chin Liang See <chin.liang....@intel.com> > > Add misc support such as EMAC and cpu info printout for Stratix SoC > > Signed-off-by: Chin Liang See <chin.liang....@intel.com> > --- > arch/arm/mach-socfpga/Makefile | 1 + > arch/arm/mach-socfpga/include/mach/misc.h | 1 + > arch/arm/mach-socfpga/misc.c | 76 ++++++++++++++++++++ > arch/arm/mach-socfpga/misc_gen5.c | 75 ++----------------- > arch/arm/mach-socfpga/misc_s10.c | 115 > ++++++++++++++++++++++++++++++ > 5 files changed, 197 insertions(+), 71 deletions(-) > create mode 100644 arch/arm/mach-socfpga/misc_s10.c >
I can see a few ways this patch can get split up to more manageable pieces. The bridge enablement can be separated. The wrap of CONFIG_SYS_L2_PL310 can be separate. The split of the emac reset can be separate. This would allow for easier review. Dinh _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
