Hi Tom,

On 22.12.2017 04:13, Tom Rini wrote:
> There are no CMDs to be run in SPL and no need for any of their lists.
> 
> CC: Stefano Babic <sba...@denx.de>
> Cc: Fabio Estevam <fabio.este...@nxp.com>
> Cc: Jagan Teki <ja...@openedev.com>
> Cc: Maxime Ripard <maxime.rip...@free-electrons.com>
> Cc: "Andreas Bießmann" <andr...@biessmann.org>
> Cc: Michal Simek <mon...@monstr.eu>
> Cc: Daniel Schwierzeck <daniel.schwierz...@gmail.com>
> Cc: Mario Six <mario....@gdsys.cc>
> Cc: Wolfgang Denk <w...@denx.de>
> Cc: York Sun <york....@nxp.com>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Bin Meng <bmeng...@gmail.com>
> Cc:Wenyou Yang <wenyou.y...@atmel.com>
> Cc: Lokesh Vutla <lokeshvu...@ti.com>
> Signed-off-by: Tom Rini <tr...@konsulko.com>
> ---
>  arch/arm/cpu/arm1136/u-boot-spl.lds           | 3 +++
>  arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds     | 3 +++
>  arch/arm/cpu/arm926ejs/orion5x/u-boot-spl.lds | 3 +++
>  arch/arm/cpu/arm926ejs/spear/u-boot-spl.lds   | 3 +++
>  arch/arm/cpu/armv7/sunxi/u-boot-spl.lds       | 3 +++
>  arch/arm/cpu/armv8/u-boot-spl.lds             | 3 +++
>  arch/arm/cpu/u-boot-spl.lds                   | 3 +++
>  arch/arm/mach-at91/arm926ejs/u-boot-spl.lds   | 3 +++
>  arch/arm/mach-at91/armv7/u-boot-spl.lds       | 3 +++
>  arch/arm/mach-omap2/u-boot-spl.lds            | 3 +++
>  arch/arm/mach-zynq/u-boot-spl.lds             | 3 +++
>  arch/microblaze/cpu/u-boot-spl.lds            | 3 +++
>  arch/mips/cpu/u-boot-spl.lds                  | 3 +++
>  arch/powerpc/cpu/mpc83xx/u-boot-spl.lds       | 3 +++
>  arch/powerpc/cpu/mpc85xx/u-boot-spl.lds       | 3 +++
>  arch/sandbox/cpu/u-boot-spl.lds               | 2 ++
>  arch/x86/cpu/u-boot-spl.lds                   | 3 +--
>  17 files changed, 48 insertions(+), 2 deletions(-)
> 

...

> diff --git a/arch/mips/cpu/u-boot-spl.lds b/arch/mips/cpu/u-boot-spl.lds
> index 07004ea11155..19444e3e600e 100644
> --- a/arch/mips/cpu/u-boot-spl.lds
> +++ b/arch/mips/cpu/u-boot-spl.lds
> @@ -11,6 +11,9 @@ OUTPUT_ARCH(mips)
>  ENTRY(_start)
>  SECTIONS
>  {
> +     /* There are no CMDs in SPL */
> +     /DISCARD/ : { *(.u_boot_list_2_cmd_*) }
> +
>       . = 0x00000000;
>  
>       . = ALIGN(4);

does a DISCARD() work together with the KEEP() in this block?

#ifdef CONFIG_SPL_DM
        . = ALIGN(4);
        .u_boot_list : {
                KEEP(*(SORT(.u_boot_list*)));
        } > .spl_mem
#endif

I suggest to do something like this:

                KEEP(*(SORT(.u_boot_list_2_uclass*)));
                KEEP(*(SORT(.u_boot_list_2_driver*)));

Then all u_boot_list_* would be discarded by default except the two
lists above when a board selects CONFIG_SPL_DM. Also this would have the
benefit of discarding all u_boot_list_2_env* entries.

-- 
- Daniel

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to