On Sat, Dec 23, 2017 at 07:07:00PM +0800, Bin Meng wrote:
> Hi Tom,
> 
> On Sat, Dec 23, 2017 at 1:01 AM, Tom Rini <[email protected]> wrote:
> > We only need to compile and link these files when building for full
> > U-Boot.  Move them to under cmd/x86/ to make sure they aren't linked in
> > and undiscarded due to u_boot_list_2_cmd_* being included).
> >
> > Cc: Bin Meng <[email protected]>
> > Signed-off-by: Tom Rini <[email protected]>
> > ---
> >  arch/x86/lib/Makefile      |   1 -
> >  arch/x86/lib/cmd_mtrr.c    | 139 -----------------------------------------
> >  arch/x86/lib/fsp/Makefile  |   1 -
> >  arch/x86/lib/fsp/cmd_fsp.c | 152 
> > ---------------------------------------------
> >  cmd/Makefile               |   2 +
> >  cmd/x86/Makefile           |   6 ++
> >  cmd/x86/cmd_fsp.c          | 152 
> > +++++++++++++++++++++++++++++++++++++++++++++
> 
> Drop the 'cmd_' prefix?
> 
> >  cmd/x86/cmd_mtrr.c         | 139 +++++++++++++++++++++++++++++++++++++++++
> 
> ditto

OK.

> >  8 files changed, 299 insertions(+), 293 deletions(-)
> >  delete mode 100644 arch/x86/lib/cmd_mtrr.c
> >  delete mode 100644 arch/x86/lib/fsp/cmd_fsp.c
> >  create mode 100644 cmd/x86/Makefile
> >  create mode 100644 cmd/x86/cmd_fsp.c
> >  create mode 100644 cmd/x86/cmd_mtrr.c
> 
> Looks the commit was not done via 'git mv'?

It was, but I didn't do git format-patch -M, I'll do that for v2.
Thanks!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to