Kever, > On 3 Jan 2018, at 03:34, Kever Yang <[email protected]> wrote: > > Hi Philipp, > > On 01/03/2018 04:16 AM, Philipp Tomsich wrote: >> The Rockchip-released ATF for the Firefly apparently (i.e. Kever >> reported this) does not tolerate a FDT being passed as the platform >> parameter and will run into a hard stop. >> >> To work around this limitation in the ATF parameter handling, we >> enable SPL_ATF_NO_PLATFORM_PARAM (which will force passing NULL for >> the platform parameters). >> >> Note that this only affects this platform, as the ATF releases for the >> RK3368 and RK3399 have always either ignored the platform parameter >> (i.e. before the FDT-based parameters were supported) or support >> receiving a pointer to a FDT. >> > > Upstream ATF of Rockchip platform support a vendor defined > " struct bl31_plat_param *bl2_param", will add support for FDT later, > see params_early_setup() in > https://github.com/ARM-software/arm-trusted-firmware/blob/master/plat/rockchip/common/params_setup.c
I have cleaning up and submitting (in the meantime, they are publicly available from our public GIT server anyway) the ATF patches on my to-do list, so let me know once this becomes urgent for you. >> Signed-off-by: Philipp Tomsich <[email protected]> > > Reviewed-by: Kever Yang <kever.yang＠rock-chips.com> > > Thanks, > - Kever >> --- >> >> configs/firefly-rk3399_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configs/firefly-rk3399_defconfig >> b/configs/firefly-rk3399_defconfig >> index ab25015..4071fea 100644 >> --- a/configs/firefly-rk3399_defconfig >> +++ b/configs/firefly-rk3399_defconfig >> @@ -15,6 +15,7 @@ >> CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py" >> CONFIG_SPL_STACK_R=y >> CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000 >> CONFIG_SPL_ATF=y >> +CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y >> CONFIG_CMD_BOOTZ=y >> CONFIG_CMD_GPT=y >> CONFIG_CMD_MMC=y >> > _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
