On 02/01/2018 23:51, Fabio Estevam wrote: > Hi Stefano, > > Looks good. Only two minor nits: > > On Tue, Jan 2, 2018 at 12:41 PM, Stefano Babic <[email protected]> wrote: > >> +int board_mmc_getcd(struct mmc *mmc) >> +{ >> + struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv; >> + int ret = 0; >> + >> + switch (cfg->esdhc_base) { >> + case USDHC2_BASE_ADDR: >> + ret = 1; >> + break; >> + } > > As this switch only handles a single case, this could be simply > written with an if.
Right 1 > >> --- /dev/null >> +++ b/include/configs/sksimx6.h >> @@ -0,0 +1,103 @@ >> +/* >> + * Copyright (C) Stefano Babic <[email protected]> >> + * >> + * SPDX-License-Identifier: GPL-2.0+ >> + */ >> + >> + >> +#ifndef __SKSIMX6_CONFIG_H >> +#define __SKSIMX6_CONFIG_H >> + >> +#include <config_distro_defaults.h> >> + >> +#include "mx6_common.h" >> +#include "imx6_spl.h" >> + >> +/* Thermal */ >> +#define CONFIG_IMX_THERMAL >> + >> +/* Serial */ >> +#define CONFIG_MXC_UART >> +#define CONFIG_MXC_UART_BASE UART1_BASE >> + >> +#define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024) > > PHYS_SDRAM_SIZE is unused as you use imx_ddr_size() to get the RAM size. I fix in V2. Thanks, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
