Dear Heiko Schocher,
In message <4b459395.2050...@denx.de> you wrote:
> This patch adds support for the Keymile SUEN3 board variants which
> are based on the Marvell Kirkwood (88F6281) SoC. All variants
> uses common code stored in board/keymile/km_arm/km_arm.c
>
> mgcoge2_arm_p1a board:
> This adds support for the ARM part of the mgcoge2. The suen3
> target was moved to the correct suen3 p1b version. There is a
> difference between the GPIO configuration between suen3 and mgcoge2.
...
> --- /dev/null
> +++ b/include/configs/km-arm.h
...
> +#if 1 // test-only cramfs ...
> +#define CONFIG_SYS_MAX_FLASH_SECT 256
Please do not add dead code (the "#if 1" here),
and do not use C++ comments (please fix this globally).
> +#ifndef __ASSEMBLY__
> +typedef struct {
> + unsigned long size; /* total bank size in bytes
> */
> + unsigned short sector_count; /* number of erase units
> */
> + unsigned long flash_id; /* combined device &
> manufacturer code */
> + unsigned long start[CONFIG_SYS_MAX_FLASH_SECT]; /* virtual sector
> start address */
> + unsigned char protect[CONFIG_SYS_MAX_FLASH_SECT]; /* sector protection
> status */
> +} flash_info_t;
Lines way too long. Please fix globally.
Umm.. why cannot you use the struct flash_info_t as declared in
"include/flash.h" ??
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A secure program has to be robust: it must be able to deal with
conditions that "can't happen", whether user input, program error or
library/etc. This is basic damage control. Buffer overflow errors
have nothing to do with security, but everything with stupidity.
-- Wietse Venema in <5cnqm3$...@spike.porcupine.org>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
