Wolfgang Denk wrote: > Dear Stefano Babic, > Hi Wolfgang,
>> +#define MXC_CCM_CBCDR_EMI_PODF_OFFSET (22) Thanks, I do it. >> +/* WEIM registers */ >> +#define CSGCR1 0x00 >> +#define CSGCR2 0x04 >> +#define CSRCR1 0x08 >> +#define CSRCR2 0x0C >> +#define CSWCR1 0x10 > > This looks like something that should be converted into a C struct. You are right. >> +#define ESDCTL_ESDCDLY5 0x30 >> +#define ESDCTL_ESDCDLYGD 0x34 > > Ditto. i can say more: this defines are not used anymore and I can drop them. I have already cleanup the code removing unnecessary defines, but it seems not enough. > >> +/* CCM */ >> +#define CLKCTL_CCR 0x00 >> +#define CLKCTL_CCDR 0x04 >> +#define CLKCTL_CSR 0x08 >> +#define CLKCTL_CCSR 0x0C >> +#define CLKCTL_CACRR 0x10 >> +#define CLKCTL_CBCDR 0x14 >> +#define CLKCTL_CBCMR 0x18 >> +#define CLKCTL_CSCMR1 0x1C They are obsolete,too. There is already a C struct describing them. I drop them. >> +#define CLKCTL_CCGR0 0x68 >> +#define CLKCTL_CCGR1 0x6C >> +#define CLKCTL_CCGR2 0x70 >> +#define CLKCTL_CCGR3 0x74 >> +#define CLKCTL_CCGR4 0x78 >> +#define CLKCTL_CCGR5 0x7C >> +#define CLKCTL_CCGR6 0x80 >> +#define CLKCTL_CMEOR 0x84 >> +/* DPLL */ >> +#define PLL_DP_CTL 0x00 >> +#define PLL_DP_CONFIG 0x04 >> +#define PLL_DP_OP 0x08 >> +#define PLL_DP_MFD 0x0C >> +#define PLL_DP_MFN 0x10 >> +#define PLL_DP_MFNMINUS 0x14 >> +#define PLL_DP_MFNPLUS 0x18 >> +#define PLL_DP_HFS_OP 0x1C >> +#define PLL_DP_HFS_MFD 0x20 >> +#define PLL_DP_HFS_MFN 0x24 >> +#define PLL_DP_TOGC 0x28 >> +#define PLL_DP_DESTAT 0x2C > > And again. This is a different fall. These defines are used in the assembly lowlevel_init.S in the first initialization. I cannot remove them. However, only a part of these defines are currently used and I will drop the rest of them. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
