On 21 January 2018 at 11:29, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > This test checks the driver for block IO devices. > A disk image is created in memory. > A handle is created for the new block IO device. > The block I/O protocol is installed on the handle. > ConnectController is used to setup partitions and to install the simple > file protocol. > A known file is read from the file system and verified. > > Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> > --- > v4 > Provide a commit message. > v3 > no change > v2 > no change > --- > lib/efi_selftest/Makefile | 3 + > lib/efi_selftest/efi_selftest_block_device.c | 395 > +++++++++++++++++++++++++++ > lib/efi_selftest/efi_selftest_disk_image.h | 69 +++++ > 3 files changed, 467 insertions(+) > create mode 100644 lib/efi_selftest/efi_selftest_block_device.c > create mode 100644 lib/efi_selftest/efi_selftest_disk_image.h
Reviewed-by: Simon Glass <s...@chromium.org> A few general comments: - I'm not very keen on using 'this' in the code. This is not C++. Can you use blkio or something, instead? - How about declaring all the static vars at the top of the file? Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
