Hi Heinrich, On 8 January 2018 at 16:11, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 01/08/2018 04:35 AM, Simon Glass wrote: >> >> Hi Heinrich, >> >> On 17 December 2017 at 08:43, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> >>> Unfortunately we need a forward declaration because both >>> OpenProtocol and CloseProtocol have to call DisconnectController. >>> And DisconnectController calls both OpenProtcol and CloseProtocol. >>> >>> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> >>> --- >>> lib/efi_loader/efi_boottime.c | 283 >>> ++++++++++++++++++++++++++++++++++++++---- >>> 1 file changed, 261 insertions(+), 22 deletions(-) >> >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> >> I think it would be good to reduce the length of some of the identifies. >> >> e.g. numbers_of_children -> child_count or num_children > > > number_of_children is what we used in the function definition in efi_api.h > and is the name of the parameter in the UEFI spec. > > I understand that you do not like bloat. But I tend to get confused when > parameter names differ from the spec.
Well please do your best. I don't think num_children is confusing. Without getting into a discussion about the merits of the spec itself I think we should try to avoid pulling its bloat into U-Boot. > > Regards > > Heinrich > > >> >> It's just too verbose for U-Boot IMO. >> >> - Simon >> > Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot