On 8.2.2018 07:01, Lokesh Vutla wrote: > Hi Michal, > > On Wednesday 07 February 2018 01:14 PM, Michal Simek wrote: >> Hi Lokesh, >> >> On 6.2.2018 13:28, Michal Simek wrote: >>> There is no reason to unconditially select network commands as distro >>> defaults without networking enable. >>> >>> Signed-off-by: Michal Simek <michal.si...@xilinx.com> >>> --- >>> >>> Changes in v2: >>> - Use if NET instead of imply (suggested by Tom) >>> - Change patch subject and description >>> >>> Kconfig | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/Kconfig b/Kconfig >>> index f713c6a9b188..166e7841b11f 100644 >>> --- a/Kconfig >>> +++ b/Kconfig >>> @@ -69,14 +69,14 @@ config DISTRO_DEFAULTS >>> imply USE_BOOTCOMMAND >>> select CMD_BOOTZ if ARM && !ARM64 >>> select CMD_BOOTI if ARM64 >>> - select CMD_DHCP >>> - select CMD_PXE >>> + select CMD_DHCP if NET >>> + select CMD_PXE if NET >>> select CMD_EXT2 >>> select CMD_EXT4 >>> select CMD_FAT >>> select CMD_FS_GENERIC >>> - select CMD_MII >>> - select CMD_PING >>> + select CMD_MII if NET >>> + select CMD_PING if NET >>> select CMD_PART >>> select HUSH_PARSER >>> help >>> >> >> Based on >> https://travis-ci.org/michalsimek/u-boot/jobs/338051973 >> >> Lokesh: >> There is an issue with omap4_sdp4430_defconfig where CONFIG_NET is not >> enabled but PXE and DHCP configs are present. >> This is quite weird and IMHO CONFIG_NET should be enabled for this target. >> This can be one resolution. > > Yeah, resolution looks good to me. Tom, any comments?
ok. I have sent a patch and feel free to comment there. Thanks, Michal _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
