On Sun, 11 Feb 2018 19:06:32 -0500 Tom Rini <[email protected]> wrote:
> On Mon, Feb 12, 2018 at 12:34:10AM +0100, Lukasz Majewski wrote: > > Hi Simon, > > > > > On 09.02.2018 23:14, Lukasz Majewski wrote: > > > > All Socfpga boards from ./include/configs/socfpga_* define > > > > CONFIG_HW_WATCHDOG. > > > > To ease CONFIG_HW_WATCHDOG conversion to Kconfig select it in > > > > config ARCH_SOCFPGA (arch/arm/Kconfig) section. > > > > > > I do have board configs where the internal watchdog is not used > > > and should be disabled (because there's an external one). Also, > > > given that this is an FPGA, I suppose having non-upstreamed > > > boards is not uncommon. > > > > I must admit that this patch I did after looking on the socfpga > > pattern in the current upstream. > > > > It seems like all boards there use HW_WATCHDOG. > > > > > > > > I'm not too familiar with these settings though: can I leave the > > > watchdog disabled when CONFIG_HW_WATCHDOG is off? Before, I just > > > haven't enabled this in my own board config... > > > > I think that I will prepare next revision of this patch with just > > simple ./tools/moveconfig.py output (without blindly selecting > > HW_WATCHDOG on all socfpga devices). > > > > In that way we will preserve the current behaviour. > > You should probably use imply for features that are common, but > optional. > Thanks for the suggestion. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
pgpqMh8iuAvyS.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
