On Tue, 13 Feb 2018 19:23:29 +0100 Heinrich Schuchardt <xypron.g...@gmx.de> wrote:
> Parameter size of function set_cluster is of type unsigned long. It
> makes no sense to convert actsize to int before passing it to
> set_cluster as size.
>
> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
> ---
> fs/fat/fat_write.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c
> index 2b753df2820..ccc03cecb6e 100644
> --- a/fs/fat/fat_write.c
> +++ b/fs/fat/fat_write.c
> @@ -679,7 +679,8 @@ set_contents(fsdata *mydata, dir_entry *dentptr,
> __u8 *buffer,
> /* set remaining bytes */
> actsize = filesize;
> - if (set_cluster(mydata, curclust, buffer,
> (int)actsize) != 0) {
> + if (set_cluster(mydata, curclust, buffer,
> + (unsigned long)actsize) != 0) {
> debug("error: writing cluster\n");
> return -1;
> }
> @@ -696,7 +697,8 @@ set_contents(fsdata *mydata, dir_entry *dentptr,
> __u8 *buffer,
> return 0;
> getit:
> - if (set_cluster(mydata, curclust, buffer,
> (int)actsize) != 0) {
> + if (set_cluster(mydata, curclust, buffer,
> + (unsigned long)actsize) != 0) {
> debug("error: writing cluster\n");
> return -1;
> }
Reviewed-by: Lukasz Majewski <lu...@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
pgpvfDqRjdn4b.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
