On Wed, Feb 14, 2018 at 6:10 PM, Faiz Abbas <faiz_ab...@ti.com> wrote:
> board_usb_init()/_cleanup() should be in board files and don't have
> a place in the xhci-omap driver. Weak versions for
> board_usb_init()/_cleanup() already exist in common/usb.c
> (for host mode) and drivers/usb/gadget/g_dnl.c (for gadget mode).
> Signed-off-by: Faiz Abbas <faiz_ab...@ti.com>
> Since 1a9a5f7 ("fix double weak board_usb_init functions") the
> board_usb_init()/_cleanup() a prefix omap_xhci_* was added to the board
> files and in omap-xhci.c because there was a duplicate implementation
> in common/usb.c. However, this broke the gadget mode path which uses the
> same board_usb_init/cleanup() in the board specific files.
> I think a better way would be to just remove the functions from xhci-omap
> like in this patch. Any issues with this?
> board/ti/am43xx/board.c | 4 ++--
> board/ti/am57xx/board.c | 4 ++--
> board/ti/dra7xx/evm.c | 4 ++--
> drivers/usb/host/xhci-omap.c | 22 ----------------------
> 4 files changed, 6 insertions(+), 28 deletions(-)
Reviewed-by: Bin Meng <bmeng...@gmail.com>
U-Boot mailing list