On Sat, Feb 24, 2018 at 05:35:06PM +0100, Miquel Raynal wrote: > Hi Maxime, > > On Thu, 22 Feb 2018 14:53:35 +0100, Maxime Ripard > <maxime.rip...@bootlin.com> wrote: > > > On Thu, Feb 22, 2018 at 02:33:41PM +0100, Miquel Raynal wrote: > > > Ensure the NAND controller reset line is deasserted before use. > > > > > > Signed-off-by: Miquel Raynal <miquel.ray...@bootlin.com> > > > --- > > > board/sunxi/board.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > > > index 8891961dcc..54ac018b80 100644 > > > --- a/board/sunxi/board.c > > > +++ b/board/sunxi/board.c > > > @@ -286,6 +286,7 @@ static void nand_clock_setup(void) > > > (struct sunxi_ccm_reg *)SUNXI_CCM_BASE; > > > > > > setbits_le32(&ccm->ahb_gate0, (CLK_GATE_OPEN << AHB_GATE_OFFSET_NAND0)); > > > + setbits_le32(&ccm->ahb_reset0_cfg, (1 << AHB_GATE_OFFSET_NAND0)); > > > > This is only relevant for the SoCs after the A31 (sun6i, sun8i, and > > probably the A80 (sun9i) and the armv8 (sun50i) families), so you > > should put an ifdef there. > > Can you tell me if something like this would fit? > > > setbits_le32(&ccm->ahb_gate0, (CLK_GATE_OPEN << > AHB_GATE_OFFSET_NAND0)); > +#if defined CONFIG_MACH_SUN6I || defined CONFIG_MACH_SUN8I || \ > + defined CONFIG_MACH_SUN9I || defined CONFIG_MACH_SUN50I
Yep, that would be better. Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
