On 03/18/2018 01:27 PM, Marek Vasut wrote:
> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote:
>> Assigning a value to ret if it is immediately overwritten does not make
>> sense.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
>
> Did you even compile-test this ? I have a feeling this file is not used
> at all, so maybe we should remove this driver.
CONFIG_USB_EHCI_FARADAY is in config_whitelist.txt.
I cannot find any place where USB_EHCI_FARADAY is actually defined.
The driver was added in 2013. I cannot not find any use in v2014.01
either. So possibly it was never used.
Regards
Heinrich
>
>> ---
>> drivers/usb/host/ehci-faraday.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/ehci-faraday.c
>> b/drivers/usb/host/ehci-faraday.c
>> index 821222cc5d..80a06bb2c0 100644
>> --- a/drivers/usb/host/ehci-faraday.c
>> +++ b/drivers/usb/host/ehci-faraday.c
>> @@ -36,7 +36,7 @@ void faraday_ehci_set_usbmode(struct ehci_ctrl *ctrl)
>>
>> int faraday_ehci_get_port_speed(struct ehci_ctrl *ctrl, uint32_t reg)
>> {
>> - int spd, ret = PORTSC_PSPD_HS;
>> + int spd, ret;
>> union ehci_faraday_regs *regs;
>>
>> ret = (void __iomem *)((ulong)ctrl->hcor - 0x10);
>>
>
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
