On 4 April 2018 at 04:01,  <linux-kernel-...@beckhoff.com> wrote:
> From: Patrick Bruenn <p.bru...@beckhoff.com>
> Add two more gpio-leds to sandbox test device tree with default-state
> property set to "on"/"off".
> Add dm_test_led_default_state() to check that these new LED's are set to
> Signed-off-by: Patrick Bruenn <p.bru...@beckhoff.com>
> ---
> patman complains about: test/dm/led.c:45: check: Please use a blank line
> after function/struct/union/enum declarations.
> I compared with other DM_TEST() usage and decided to ignore this check.
> Should we fix the macro, patman or keep ignoring this?

Yes you can ignore it. The warning is coming from checkpatch.pl. I
suppose we could update that. I think the macro should be next to the
function it references, otherwise it gets a bit confusing.

> Changes in v3: None
> Changes in v2: None
>  arch/sandbox/dts/test.dts | 12 ++++++++++++
>  test/dm/led.c             | 16 ++++++++++++++++
>  2 files changed, 28 insertions(+)

Reviewed-by: Simon Glass <s...@chromium.org>
U-Boot mailing list

Reply via email to