On Mon, Apr 9, 2018 at 3:05 AM, Dr. Philipp Tomsich
<philipp.toms...@theobroma-systems.com> wrote:
>
>> On 9 Apr 2018, at 10:01, Neil Armstrong <narmstr...@baylibre.com> wrote:
>>
>> On 30/03/2018 18:52, Joe Hershberger wrote:
>>> Some boards expect to find more than one phy while other boards are old
>>> and need to be limited to a specific phy address. Only limit the phy
>>> address for boards that opt in.
>>>
>>> Signed-off-by: Joe Hershberger <joe.hershber...@ni.com>
>
> Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com>
>
> See below for recommended change.
>
>>>
>>> ---
>>>
>>> configs/am335x_baltos_defconfig            | 1 +
>>> configs/am335x_shc_defconfig               | 1 +
>>> configs/am335x_shc_ict_defconfig           | 1 +
>>> configs/am335x_shc_netboot_defconfig       | 1 +
>>> configs/am335x_shc_prompt_defconfig        | 1 +
>>> configs/am335x_shc_sdboot_defconfig        | 1 +
>>> configs/am335x_shc_sdboot_prompt_defconfig | 1 +
>>> configs/devkit3250_defconfig               | 1 +
>>> configs/ds414_defconfig                    | 1 +
>>> configs/khadas-vim_defconfig               | 1 +
>>> configs/libretech-cc_defconfig             | 1 +
>>> configs/p212_defconfig                     | 1 +
>>> configs/pepper_defconfig                   | 1 +
>>> configs/work_92105_defconfig               | 1 +
>>> configs/x600_defconfig                     | 1 +
>>> drivers/net/phy/Kconfig                    | 8 ++++++++
>>> 16 files changed, 23 insertions(+)

[...]

>>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
>>> index 179e041..f5821df 100644
>>> --- a/drivers/net/phy/Kconfig
>>> +++ b/drivers/net/phy/Kconfig
>>> @@ -13,12 +13,20 @@ menuconfig PHYLIB
>>>
>>> if PHYLIB
>>>
>>> +config PHY_ADDR_ENABLE
>>> +    bool "Limit phy address"
>>> +    default y if ARCH_SUNXI
>
> Not happy about this one being in this specific Kconfig.
> This should be an ‘default’ or 'imply’ over in the sunxi top-level Kconfig 
> (i.e. whereever ARCH_SUNXI is declared).
>

Patches welcome. I'm not sure how Kconfig would react to that.

>>> +    help
>>> +      Select this if you want to control which phy address is used
>>> +
>>> +if PHY_ADDR_ENABLE
>>> config PHY_ADDR
>>>      int "PHY address"
>>>      default 1 if ARCH_SUNXI
>>>      default 0
>>>      help
>>>        The address of PHY on MII bus. Usually in range of 0 to 31.
>>> +endif
>>>
>>> config B53_SWITCH
>>>      bool "Broadcom BCM53xx (RoboSwitch) Ethernet switch PHY support."
>>>
>> Hi,
>>
>> For p212, libretech-cc and khadas-vim,
>>
>> Acked-by: Neil Armstrong <narmstr...@baylibre.com 
>> <mailto:narmstr...@baylibre.com>>
>>
>> Neil
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to