On 10.04.2018 10:09, Alex Kiernan wrote:
> On Tue, Apr 10, 2018 at 8:04 AM, Felix Brack <f...@ltec.ch> wrote:
>> On 10.04.2018 09:47, Alex Kiernan wrote:
>>> On Tue, Apr 10, 2018 at 7:21 AM, Felix Brack <f...@ltec.ch> wrote:
>>>> Hi Tom,
>>>> On 09.04.2018 17:03, Tom Rini wrote:
>>>>> On Sun, Apr 01, 2018 at 09:22:34AM +0000, Alex Kiernan wrote:
>>>>>> This converts CONFIG_DRIVER_TI_CPSW to Kconfig
>>>>>> Signed-off-by: Alex Kiernan <alex.kier...@gmail.com>
>>>>>> Acked-by: Joe Hershberger <joe.hershber...@ni.com>
>>>>> Applied to u-boot/master, thanks!
>>>> Why did you apply this patch? It introduces a build warning?
>>> Sorry, we probably want to revert this one, or try adding "depends on
>>> NET" to DRIVER_TI_CPSW in drivers/net/Kconfig; I'm stuck without a
>>> laptop until the end of the week so I've not been able to get back to
>>> fix this :(
>> Please do _not_ add this dependency to "solve" the build problem I
>> reported. This would just blow up the U-Boot code for the PDU001 board.
>> As already stated: it is best to remove CONFIG_DRIVER_TI_CPSW=y from
>> configs/am335x_pdu001_defconfig leaving this file unchanged.
> That only fixes that one board - agreed, it wants removing from that
> config, but there's doubtless others which don't have NET enabled. My
> thinking was add the depends and then redo the moveconfig which would
> then remove it from all other boards too.
Okay, I see. As I'm the maintainer of this board, that was my only
focus. My focus was not on the patch as a whole, sorry.

> Tom, probably best to revert this one and I'll get a correct patch
> done when I'm back (should be early next week).
Agreed. However, knowing that it will get fixed, I could also live with
that warning for some weeks ;)


U-Boot mailing list

Reply via email to