Hi Matt, On 27.03.2018 19:53, Matt Pelland wrote:
The mv_sdhci driver was not zeroing the sdhci_host structure it allocates causing random access violations in parts of the mmc core where the "ops" member pointers are checked and called if not NULL.Signed-off-by: Matt Pelland <mpell...@starry.com> --- drivers/mmc/mv_sdhci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c index 69aa87babe..afc03f75a0 100644 --- a/drivers/mmc/mv_sdhci.c +++ b/drivers/mmc/mv_sdhci.c @@ -74,6 +74,8 @@ int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks) return -ENOMEM; }+ memset(host, 0, sizeof(struct sdhci_host));+ host->name = MVSDH_NAME; host->ioaddr = (void *)regbase; host->quirks = quirks;
Thanks for finding this. But please use calloc() instead of malloc() and the memset can be dropped. Thanks, Stefan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
