On Thu, Apr 19, 2018 at 12:17 PM, Scott Wood <o...@buserror.net> wrote: > On Mon, 2018-04-16 at 08:40 +0530, Calvin Johnson wrote: >> On Fri, Apr 13, 2018 at 12:18 AM, Jagdish Gediya <jagdish.ged...@nxp.com> >> wrote: >> > Add command "boot_bank X" to switch the boot bank to either >> > 1 or 2. >> >> Are these functions required as this can be handled by new env vars to >> switch banks? > > If you're going to add something new, a command is much more pleasant than env > vars -- particularly if you stick to something like the familiar interfaces > ("pix altbank", "qix altbank", etc), and include reporting of which bank was > booted from if it's not there already. Of course, a fully standardized > interface would be even better.
Yes, a fully standardized generic interface supporting all similar platforms with multiple banks would be better. What this patch currently does can be done with simple env vars, like : setenv boot_bank_1 'i2c mw 0x24 0x7 0xfc; i2c mw 0x24 0x3 0xf5' setenv boot_bank_2 'i2c mw 0x24 0x7 0xfc; i2c mw 0x24 0x3 0xf4' regards Calvin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot