On Thu, Apr 19, 2018 at 04:52:30AM +0000, Alex Kiernan wrote: > > On the face of it, this is a straightforward moveconfig, but because > of how CONFIG_FIT_SIGNATURE, CONFIG_IMAGE_FORMAT_LEGACY and > CONFIG_DISABLE_IMAGE_LEGACY interacted when you enabled > CONFIG_FIT_SIGNATURE, you got CONFIG_IMAGE_FORMAT_LEGACY disabled > immediately unless you had some way of explicitly enabling it > elsewhere. > > Kconfig doesn't give us this - CONFIG_IMAGE_FORMAT_LEGACY starts off > enabled, CONFIG_FIT_SIGNATURE starts off disabled and if you enable > CONFIG_FIT_SIGNATURE then CONFIG_IMAGE_FORMAT_LEGACY stays enabled. > > Is there some way to preserve the existing behaviour through Kconfig > that I've failed to figure out?
When I do these, it's a multi-step moveconfig.py that goes something like: - Introduce FOO (no deps) - moveconfig.py -y it. - Introduce BAR (no deps) - moveconfig.py -y it. - for FILE in configs/*defconfig;do grep -q FOO $FILE || echo '# CONFIG_FOO is not set' >> $FILE;done - Repeat the for loop but for BAR. - Introduce deps - moveconfig.py -sC - Build before/after for a few boards that I know are tricky, use buildman -SCvel/Ssdel to confirm size changes didn't happen. - If good, world-build checking sizes. And in some cases like this particular one, there might need to be an initial first comment to invert the logic, and as that can be tricky when adding a new option that _should_ be default y, first I add it without default y, moveconfig.py -y it, for loop like above, then add default y and moveconfig.py -s. -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
