On Tue, Apr 24, 2018 at 11:24:51AM +0200, Neil Armstrong wrote:
> The Libre Computer Board ALL-H3-CC from Libre Technology is a Raspberry
> Pi B+ form factor single board computer based on the Allwinner H3 or H5 SoC.
> The board has 1GB DDR3 SDRAM, provided by 4 2Gb chips. The mounting holes
> and connectors are in the exact same position as on the Raspberry Pi B+.
> 
> This patch adds defconfig and dts files for the H5 variant of the same board.
> The dts file simply includes the H3 variant since the board is the same.
> 
> The defconfig is based on the H3 variant and adapted to build for the H5.
> 
> This follows the corresponding Linux patchset at [1].
> 
> [1] 
> http://lkml.kernel.org/r/[email protected]
> 
> Signed-off-by: Neil Armstrong <[email protected]>

Commit log should be wrapped at 75 chars.

> ---
>  arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts | 12 ++++++++++++
>  configs/libretech_all_h3_cc_h5_defconfig       | 17 +++++++++++++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts
>  create mode 100644 configs/libretech_all_h3_cc_h5_defconfig
> 
> diff --git a/arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts 
> b/arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts
> new file mode 100644
> index 0000000..a72b0a3
> --- /dev/null
> +++ b/arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2018 BayLibre, SAS
> + * Author: Neil Armstrong <[email protected]>
> + */
> +
> +#include "sun8i-h3-libretech-all-h3-cc.dts"
> +
> +/ {
> +     model = "Libre Computer Board ALL-H3-CC H5";
> +     compatible = "libretech,all-h3-cc-h5", "allwinner,sun50i-h5";
> +};

The DT will not be correct in that case, especially the CPU node. Why
not using the same DT than Linux?

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to