In U-Boot it is usually written this way.
Signed-off-by: Marek Behun <marek.be...@nic.cz>
Reviewed-by: Stefan Roese <s...@denx.de>
---
drivers/phy/marvell/comphy_a3700.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/phy/marvell/comphy_a3700.c
b/drivers/phy/marvell/comphy_a3700.c
index 0c06c00796..429ad6b018 100644
--- a/drivers/phy/marvell/comphy_a3700.c
+++ b/drivers/phy/marvell/comphy_a3700.c
@@ -215,7 +215,7 @@ static int comphy_pcie_power_up(u32 speed, u32 invert)
rb_txdclk_pclk_en, /* value */
rb_txdclk_pclk_en, /* mask */
POLL_16B_REG); /* 16bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to lock PCIe PLL\n");
debug_exit();
@@ -284,7 +284,7 @@ static int comphy_sata_power_up(void)
bs_pll_ready_tx, /* value */
bs_pll_ready_tx, /* mask */
POLL_32B_REG); /* 32bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to lock SATA PLL\n");
debug_exit();
@@ -413,7 +413,7 @@ static int comphy_usb3_power_up(u32 type, u32 speed, u32
invert)
rb_txdclk_pclk_en, /* value */
rb_txdclk_pclk_en, /* mask */
POLL_16B_REG); /* 16bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to lock USB3 PLL\n");
/*
@@ -493,7 +493,7 @@ static int comphy_usb2_power_up(u8 usb32)
rb_usb2phy_pllcal_done, /* value */
rb_usb2phy_pllcal_done, /* mask */
POLL_32B_REG); /* 32bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to end USB2 PLL calibration\n");
/* Assert impedance calibration done */
@@ -501,7 +501,7 @@ static int comphy_usb2_power_up(u8 usb32)
rb_usb2phy_impcal_done, /* value */
rb_usb2phy_impcal_done, /* mask */
POLL_32B_REG); /* 32bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to end USB2 impedance calibration\n");
/* Assert squetch calibration done */
@@ -509,7 +509,7 @@ static int comphy_usb2_power_up(u8 usb32)
rb_usb2phy_sqcal_done, /* value */
rb_usb2phy_sqcal_done, /* mask */
POLL_32B_REG); /* 32bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to end USB2 unknown calibration\n");
/* Assert PLL is ready */
@@ -518,7 +518,7 @@ static int comphy_usb2_power_up(u8 usb32)
rb_usb2phy_pll_ready, /* mask */
POLL_32B_REG); /* 32bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to lock USB2 PLL\n");
debug_exit();
@@ -766,7 +766,7 @@ static int comphy_sgmii_power_up(u32 lane, u32 speed, u32
invert)
rb_pll_ready_tx | rb_pll_ready_rx, /* value */
rb_pll_ready_tx | rb_pll_ready_rx, /* mask */
POLL_32B_REG); /* 32bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to lock PLL for SGMII PHY %d\n", lane);
/*
@@ -788,7 +788,7 @@ static int comphy_sgmii_power_up(u32 lane, u32 speed, u32
invert)
rb_rx_init_done, /* value */
rb_rx_init_done, /* mask */
POLL_32B_REG); /* 32bit */
- if (ret == 0)
+ if (!ret)
printf("Failed to init RX of SGMII PHY %d\n", lane);
debug_exit();
@@ -819,7 +819,7 @@ void comphy_dedicated_phys_init(void)
if (node > 0) {
if (fdtdec_get_is_enabled(blob, node)) {
ret = comphy_usb2_power_up(usb32);
- if (ret == 0)
+ if (!ret)
printf("Failed to initialize UTMI
PHY\n");
else
debug("UTMI PHY init succeed\n");
@@ -837,7 +837,7 @@ void comphy_dedicated_phys_init(void)
if (node > 0) {
if (fdtdec_get_is_enabled(blob, node)) {
ret = comphy_sata_power_up();
- if (ret == 0)
+ if (!ret)
printf("Failed to initialize SATA PHY\n");
else
debug("SATA PHY init succeed\n");
@@ -858,7 +858,7 @@ void comphy_dedicated_phys_init(void)
if (node > 0) {
if (fdtdec_get_is_enabled(blob, node)) {
ret = comphy_emmc_power_up();
- if (ret == 0)
+ if (!ret)
printf("Failed to initialize SDIO/eMMC PHY\n");
else
debug("SDIO/eMMC PHY init succeed\n");
@@ -916,7 +916,7 @@ int comphy_a3700_init(struct chip_serdes_phy_config
*chip_cfg,
ret = 1;
break;
}
- if (ret == 0)
+ if (!ret)
printf("PLL is not locked - Failed to initialize lane
%d\n",
lane);
}
--
2.16.1
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
