On Wed, May 02, 2018 at 09:08:11AM +0200, Lukasz Majewski wrote:

> Those two functions can be used to provide easy bootcount management.
> 
> Signed-off-by: Lukasz Majewski <[email protected]>
[snip]

> +#if defined CONFIG_SPL_BOOTCOUNT_LIMIT || defined CONFIG_BOOTCOUNT_LIMIT
> +
>  #if !defined(CONFIG_SYS_BOOTCOUNT_LE) && !defined(CONFIG_SYS_BOOTCOUNT_BE)

Style problem.  We have a few places where we don't use parens in the
code today, but this is the first time I've noticed and had to check
quickly to see that.  Please follow the normal convention of if
defined(FOO) ....  Otherwise:

Reviewed-by: Tom Rini <[email protected]>

And, erm, since you'll need to repost this one, please v5 the whole
series since you accidentally did v3 again in the subject just to make
it extra easy to see what version I should pull in later?  Thanks!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Reply via email to