Dear Tom, In message <[email protected]> I wrote: > > > - Don't like // style comments > > - Visually inconsistent / jarring > > - Against existing coding style.
Also, the SPDX tag is rarely a separate comment line. In most cases, it is part of a larger file header, say for example: common/main.c: /* * (C) Copyright 2000 * Wolfgang Denk, DENX Software Engineering, [email protected]. * * SPDX-License-Identifier: GPL-2.0+ */ Do you suggest to reformat this into something like: /* * (C) Copyright 2000 * Wolfgang Denk, DENX Software Engineering, [email protected]. */ // SPDX-License-Identifier: GPL-2.0+ ? If yes, then please explain which sense this would make? It is just unnecessay work, and the result is inconsistent and ugly. > > - Has tooling to enforce correctly formatted tags. I forgot to ask which "tooling" you have in mind here? I did not see anything like that in the kernel source tree. What am I missing? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] This restaurant was advertising breakfast any time. So I ordered french toast in the renaissance. - Steven Wright, comedian _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
