Hi,
> -----Original Message-----
> From: Alex Kiernan [mailto:alex.kier...@gmail.com]
> Sent: Thursday, May 17, 2018 1:31 PM
> To: Vipul Kumar <vip...@xilinx.com>
> Cc: u-boot <u-boot@lists.denx.de>; gmus...@ciena.com; Michal Simek
> <michal.si...@xilinx.com>; Siva Durga Prasad Paladugu
> <siva...@xilinx.com>
> Subject: Re: [U-Boot] [UBOOT PATCH] env: mmc: Fix misaligned buffer
> address when saving envvars to FAT
>
> On Thu, May 17, 2018 at 8:46 AM Vipul Kumar <vipul.ku...@xilinx.com>
> wrote:
>
> > From: Gary Mussar <gmus...@ciena.com>
>
> > When doing a u-boot saveenv with the environment in FAT we see the
> > following warning:
>
> > ZynqMP> saveenv
> > Saving Environment to FAT...
> > writing uboot.env
> > FAT: Misaligned buffer address (000000007deb9b60) done
>
> > This can be eliminated by aligning the environment to an appropriate
> > boundary.
>
>
> Are you still seeing after this commit?
With cda87ec commit, it's working fine. I didn’t test with this commit earlier.
So, there is no need of this patch.
Regards,
Vipul
>
> cda87ec Fix misaligned buffer in env_fat_save
>
> > Signed-off-by: Gary Mussar <gmus...@ciena.com>
> > Signed-off-by: Vipul Kumar <vipul.ku...@xilinx.com>
> > ---
> > include/environment.h | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
>
> > diff --git a/include/environment.h b/include/environment.h index
> > 50c62c5..d6c530d 100644
> > --- a/include/environment.h
> > +++ b/include/environment.h
> > @@ -150,7 +150,11 @@ typedef struct environment_s {
> > unsigned char flags; /* active/obsolete flags */
> > #endif
> > unsigned char data[ENV_SIZE]; /* Environment data */
> > -} env_t;
> > +} env_t
> > +#ifdef ARCH_DMA_MINALIGN
> > +__aligned(ARCH_DMA_MINALIGN)
> > +#endif
> > +;
>
> > #ifdef ENV_IS_EMBEDDED
> > extern env_t environment;
> > --
> > 2.7.4
>
> > This email and any attachments are intended for the sole use of the
> > named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copyrighted under applicable law. If you are not the intended
> recipient, do not read, copy, or forward this email message or any
> attachments. Delete this email message and any attachments immediately.
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
>
>
>
> --
> Alex Kiernan
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
