On Thu, May 17, 2018 at 01:59:36PM +0200, Stefan Roese wrote:
> On 17.05.2018 13:53, Chris Packham wrote:
> >
> >
> >On Thu, 17 May 2018, 11:09 PM Tom Rini, <tr...@konsulko.com
> ><mailto:tr...@konsulko.com>> wrote:
> >
> >    On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote:
> >     > Not all users of MVGBE need PHYLIB and it increases the size of the
> >     > openrd images too much.
> >     >
> >     > Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE")
> >     > Signed-off-by: Chris Packham <judge.pack...@gmail.com
> >    <mailto:judge.pack...@gmail.com>>
> >     > Cc: Tom Rini <tr...@konsulko.com <mailto:tr...@konsulko.com>>
> >     > Cc: Stefan Roese <s...@denx.de <mailto:s...@denx.de>>
> >     > ---
> >     >
> >     >  drivers/net/Kconfig | 1 -
> >     >  1 file changed, 1 deletion(-)
> >     >
> >     > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> >     > index c962d7a72c0c..f2cc75f494e8 100644
> >     > --- a/drivers/net/Kconfig
> >     > +++ b/drivers/net/Kconfig
> >     > @@ -181,7 +181,6 @@ config FTMAC100
> >     >  config MVGBE
> >     >       bool "Marvell Orion5x/Kirkwood network interface support"
> >     >       depends on KIRKWOOD || ORION5X
> >     > -     select PHYLIB
> >     >       help
> >     >         This driver supports the network interface units in the
> >     >         Marvell Orion5x and Kirkwood SoCs
> >
> >    This results in phylib never being set now as the configs were getting
> >    it implicitly.  Do any of the boards need it?
> >
> >
> >I compile tested the affected boards and they all build. I've fired this
> >at github and should have some travis results soon.
> >
> >My mistake was to copy the mvneta kconfig which had the select. Commit
> >ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any CONFIG_PHYLIB
> >lines so if they need it it's already in the board.h file or selected
> >somewhere else.
> 
> Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for
> MVGBE") selected PHYLIB via Kconfig, which changed the configuration
> for these Kirkwood boards. *If* some of them needed / selected PHYLIB
> before this patch, it was most likely done in their config header.
> 
> So this patch restores the board configuration again. PHYLIB is not
> needed for MVGBE - it compiles without it as well.

OK, thanks.  Can you please do a v2 with a commit message that reflects
this and a Fixes tag?

-- 
Tom

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to