2018-06-13 5:45 GMT+09:00 Joe Hershberger <joe.hershber...@ni.com>:
> On Thu, May 24, 2018 at 5:24 AM, Kunihiko Hayashi
> <hayashi.kunih...@socionext.com> wrote:
>> Add driver for Socionext AVE ethernet controller that includes MAC and
>> MDIO bus supporting RGMII/RMII modes.
>> The driver behaves the ethernet driver model (DM_ETH) with devicetree.




>> This patch requires the internal phy definition [1].
>> [1] http://patchwork.ozlabs.org/patch/915965/


This comment should be ripped off
when this is applied.

It should have been under '---' line.



>> Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
>> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
>
> Looks great!
>
> Acked-by: Joe Hershberger <joe.hershber...@ni.com>


Could you apply this with the prerequisite patch please?




>> ---
>>  drivers/net/Kconfig   |  10 +
>>  drivers/net/Makefile  |   1 +
>>  drivers/net/sni_ave.c | 995 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 1006 insertions(+)
>
> Any plan to enable this driver in a defconfig so that it is build tested?

No worry.  I maintain uniphier_*_defconfig

We can enable the driver as needed
after this driver lands.





-- 
Best Regards
Masahiro Yamada
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to