Hi Simon, On Fri, May 25, 2018 at 4:41 AM, Simon Glass <s...@chromium.org> wrote: > On 23 May 2018 at 06:10, Mario Six <mario....@gdsys.cc> wrote: >> Add a uclass for AXI (Advanced eXtensible Interface) busses, and a >> driver for the gdsys IHS AXI bus on IHS FPGAs. >> >> Signed-off-by: Mario Six <mario....@gdsys.cc> >> >> --- >> >> v1 -> v2: >> * Spelled out all abbreviations in the Kconfig help >> * Split commit into uclass addition and driver addition >> >> --- >> drivers/Kconfig | 2 ++ >> drivers/Makefile | 1 + >> drivers/axi/Kconfig | 13 +++++++++ >> drivers/axi/Makefile | 8 ++++++ >> drivers/axi/axi-uclass.c | 40 ++++++++++++++++++++++++++ >> include/axi.h | 75 >> ++++++++++++++++++++++++++++++++++++++++++++++++ >> include/dm/uclass-id.h | 1 + >> 7 files changed, 140 insertions(+) >> create mode 100644 drivers/axi/Kconfig >> create mode 100644 drivers/axi/Makefile >> create mode 100644 drivers/axi/axi-uclass.c >> create mode 100644 include/axi.h > > Reviewed-by: Simon Glass <s...@chromium.org> > > One little nit: > >> diff --git a/include/dm/uclass-id.h b/include/dm/uclass-id.h >> index d7f9df3583a..0aad4bc14d7 100644 >> --- a/include/dm/uclass-id.h >> +++ b/include/dm/uclass-id.h >> @@ -43,6 +43,7 @@ enum uclass_id { >> UCLASS_I2C_GENERIC, /* Generic I2C device */ >> UCLASS_I2C_MUX, /* I2C multiplexer */ >> UCLASS_IDE, /* IDE device */ >> + UCLASS_AXI, /* AXI busses */ > > AXI bus >
Sure, will fix for v3. >> UCLASS_IRQ, /* Interrupt controller */ >> UCLASS_KEYBOARD, /* Keyboard input device */ >> UCLASS_LED, /* Light-emitting diode (LED) */ >> -- >> 2.11.0 >> > Best regards, Mario _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot