On Thu, Jun 28, 2018 at 03:57:24PM +0800, Bin Meng wrote: > Hi Ivan, > > On Wed, Jun 27, 2018 at 11:41 PM, Ivan Gorinov <ivan.gori...@intel.com> wrote: > > EFI image handle and system table are not used in _relocate(). > > > > v3: > > Rebased on u-boot/master > > > > v2: > > Separated the changes in efi_main() arguments and calling convention. > > > > Ivan Gorinov (3): > > x86: Remove unused _relocate arguments > > I don't understand the v3 patch now. > > In previous v1/v2 patch, you did not change x86's _relocate() to > declare EFIAPI, but in v3, you suddenly added EFIAPI to the x86 > version but without adding EFIAPI to arm and risv, why?
Keeping default calling convention in v2 was a mistake because the x86_64 startup code passes _relocate() arguments using EFI convention. I will submit another version that consistently uses EFIAPI in _relocate(). > > > arm: Remove unused _relocate arguments > > riscv: Remove unused _relocate arguments > > > > arch/arm/lib/crt0_aarch64_efi.S | 2 -- > > arch/arm/lib/crt0_arm_efi.S | 2 -- > > arch/arm/lib/reloc_aarch64_efi.c | 3 +-- > > arch/arm/lib/reloc_arm_efi.c | 3 +-- > > arch/riscv/lib/reloc_riscv_efi.c | 3 +-- > > arch/x86/lib/crt0_x86_64_efi.S | 3 --- > > arch/x86/lib/reloc_ia32_efi.c | 3 +-- > > arch/x86/lib/reloc_x86_64_efi.c | 3 +-- > > 8 files changed, 5 insertions(+), 17 deletions(-) > > > > Regards, > Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot