On Wed, Jul 11, 2018 at 12:23 PM, Vasily Khoruzhick <[email protected]> wrote: > On Mon, Jul 9, 2018 at 12:17 PM, Jagan Teki <[email protected]> > wrote: >> Only H3 and H5 have 4 PHYS so restrict rst_mask only for them. >> >> Signed-off-by: Jagan Teki <[email protected]> >> --- >> drivers/phy/allwinner/phy-sun4i-usb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c >> b/drivers/phy/allwinner/phy-sun4i-usb.c >> index 3096f12c1c..81fcd1f910 100644 >> --- a/drivers/phy/allwinner/phy-sun4i-usb.c >> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c >> @@ -117,7 +117,7 @@ struct sun4i_usb_phy_info { >> .gpio_vbus = CONFIG_USB3_VBUS_PIN, >> .gpio_vbus_det = NULL, >> .gpio_id_det = NULL, >> -#ifdef CONFIG_MACH_SUN6I >> +#ifdef CONFIG_MACH_SUNXI_H3_H5 > > It should be handled by compatibles, not ifdefs. Phy driver is proper > DM driver, so you can use .data in device ids array.
True, but since it' already have ifdef and more over this code will drop very soon, we are planning to support CLK and RST[1] (max of v2018.11). [1] https://github.com/amarula/u-boot-amarula/commits/sun-dev _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
